refactor: migrate library repository to kysely #15271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
force-pushed
the
refactor/kysely-library
branch
2 times, most recently
from
26b3d5a to
48790d0
Compare
mertalev
reviewed
Jan 13, 2025
mertalev
reviewed
Jan 13, 2025
mertalev
reviewed
Jan 13, 2025
danieldietzler
force-pushed
the
refactor/kysely-library
branch
from
48790d0 to
9415b57
Compare
jrasm91
approved these changes
Jan 14, 2025
| create(library: Insertable<Libraries>): Promise<LibraryEntity> { | ||
| return this.db | ||
| .insertInto('libraries') | ||
| .values(library as LibraryEntity) |
There was a problem hiding this comment.
Left over from an earlier method signature, ty!
danieldietzler
force-pushed
the
refactor/kysely-library
branch
2 times, most recently
from
520d6e3 to
a910de3
Compare
danieldietzler
force-pushed
the
refactor/kysely-library
branch
from
a910de3 to
ee4775b
Compare
mertalev
approved these changes
Jan 14, 2025
etnoy
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.