web/settings/audio: disable bitrate section when not applicable #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wukko
requested changes
Oct 4, 2024
wukko
requested changes
Oct 4, 2024
| @@ -7,6 +7,7 @@ | |||
| import Switcher from "$components/buttons/Switcher.svelte"; | |||
| import SettingsButton from "$components/buttons/SettingsButton.svelte"; | |||
| import SettingsToggle from "$components/buttons/SettingsToggle.svelte"; | |||
| import settings from "$lib/state/settings"; | |||
There was a problem hiding this comment.
this import should be on very top, before translations
| @@ -23,7 +24,7 @@ | |||
| </Switcher> | |||
| </SettingsCategory> | |||
|
|
|||
| <SettingsCategory sectionId="bitrate" title={$t("settings.audio.bitrate")}> | |||
| <SettingsCategory sectionId="bitrate" title={$t("settings.audio.bitrate")} disabled={["wav", "best"].includes($settings.save.audioFormat)}> | |||
There was a problem hiding this comment.
please expand this line into something like this, it's way too long
<SettingsCategory
sectionId="bitrate"
title={$t("settings.audio.bitrate")}
disabled={["wav", "best"].includes($settings.save.audioFormat)}
>
wukko
requested changes
Oct 4, 2024
web/i18n/en/settings.json
Outdated
| @@ -50,7 +50,7 @@ | |||
|
|
|||
| "audio.bitrate": "audio bitrate", | |||
| "audio.bitrate.kbps": "kb/s", | |||
| "audio.bitrate.description": "bitrate applies only to audio conversion. cobalt can't improve the source audio quality, so choosing a bitrate over 128kbps may inflate the file size with no audible difference. perceived quality may vary by format.", | |||
| "audio.bitrate.description": "bitrate only applies to audio conversion into lossy audio formats. cobalt can't improve the source audio quality, so choosing a bitrate over 128kbps may inflate the file size with no audible difference. perceived quality may vary by format.", | |||
There was a problem hiding this comment.
"bitrate is applied only when converting audio to a lossy format."
wukko
requested changes
Oct 4, 2024
wukko
reviewed
Oct 5, 2024
wukko
approved these changes
Oct 5, 2024
wukko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please delete my closed pr thanks :3
if the audio format is either
bestorwav,the bitrate selector should be greyed out,
cause it's lossless, or not necessarily re-encoded.