Merge pull request #111 from inaka/elbrujohalcon.111.code_cleanup

Code cleanup
inaka · Jan 5, 2015 · cf98017 · cf98017
2 parents 3640636 + d5199f7
commit cf98017
Show file tree

Hide file tree

Showing 16 changed files with 425 additions and 140 deletions.
diff --git a/Makefile b/Makefile
@@ -12,6 +12,10 @@ dep_wpool = git https://github.com/inaka/worker_pool.git 1.0
 TEST_DEPS = mixer
 dep_mixer = git git://github.com/inaka/mixer.git 0.1.2
 
+DIALYZER_DIRS := ebin/
+DIALYZER_OPTS := --verbose --statistics -Werror_handling \
+                 -Wrace_conditions #-Wunmatched_returns
+
 include erlang.mk
 
 ERLC_OPTS += +'{parse_transform, lager_transform}'

diff --git a/elvis.config b/elvis.config
@@ -5,46 +5,47 @@
     {config,
      [#{dirs => ["src", "test"],
         filter => "*.erl",
-        rules => [{elvis_style, line_length, [80]},
-                  {elvis_style, no_tabs, []},
-                  {elvis_style, macro_names, []},
-                  {elvis_style, macro_module_names, []},
-                  {elvis_style, operator_spaces, [{right, ","},
-                                                  {right, "++"},
-                                                  {left, "++"}]},
-                  {elvis_style, nesting_level, [3]},
-                  {elvis_style, god_modules, [25]},
-                  {elvis_style, no_if_expression, []},
+        rules => [{elvis_style, line_length, #{limit => 80}},
+                  {elvis_style, no_tabs},
+                  {elvis_style, macro_names},
+                  {elvis_style, macro_module_names},
+                  {elvis_style, operator_spaces, #{rules => [{right, ","},
+                                                             {right, "++"},
+                                                             {left, "++"}]}},
+                  {elvis_style, nesting_level, #{level => 3}},
+                  {elvis_style, god_modules, #{limit => 25}},
+                  {elvis_style, no_if_expression},
                   {elvis_style,
                    invalid_dynamic_call,
-                   [conditional_logic_SUITE,
-                    sumo_find_SUITE,
-                    sumo_basic_SUITE,
-                    sumo,
-                    sumo_internal]
+                   #{ignore =>
+                     [conditional_logic_SUITE,
+                      sumo_find_SUITE,
+                      sumo_basic_SUITE,
+                      sumo,
+                      sumo_internal]}
                   },
-                  {elvis_style, used_ignored_variable, []},
-                  {elvis_style, no_behavior_info, []},
+                  {elvis_style, used_ignored_variable},
+                  {elvis_style, no_behavior_info},
                   {
                     elvis_style,
                     module_naming_convention,
-                    ["^([a-z][a-z0-9]*_?)*(_SUITE)?$", []]
+                    #{regex => "^([a-z][a-z0-9]*_?)*(_SUITE)?$", ignore => []}
                   },
-                  {elvis_style, state_record_and_type, []},
-                  {elvis_style, no_spec_with_records, []}
+                  {elvis_style, state_record_and_type},
+                  {elvis_style, no_spec_with_records}
                  ]
        },
       #{dirs => ["."],
         filter => "Makefile",
-        rules => [{elvis_project, no_deps_master_erlang_mk, []}]
+        rules => [{elvis_project, no_deps_master_erlang_mk, #{ignore => []}}]
        },
       #{dirs => ["."],
         filter => "rebar.config",
-        rules => [{elvis_project, no_deps_master_rebar, []}]
+        rules => [{elvis_project, no_deps_master_rebar, #{ignore => []}}]
        },
       #{dirs => ["."],
         filter => "elvis.config",
-        rules => [{elvis_project, old_configuration_format, []}]
+        rules => [{elvis_project, old_configuration_format}]
        }
      ]
     }