Added Unit Test for Republisher Node on Noetic Branch #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IrinaTerebiznik
changed the title
IrinaTerebiznik
changed the title
leandropineda
requested changes
Dec 24, 2024
There was a problem hiding this comment.
Reviewed! The test looks good, I added a few questions and change requests.
Also, please rename the UnitTests folder to use lowecase and underscores, as we adhere to PEP8 style guide: https://peps.python.org/pep-0008/#package-and-module-names
Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability. Python packages should also have short, all-lowercase names, although the use of underscores is discouraged.
…republisher.test ' s path to config file
…nt errors in the future and improve scalability
leandropineda
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository contains a unit test for a ROS node that republishes messages from
/input_topicto/output_topic. The test ensures the republisher node processes and republishes messages correctly.Note that this test is non-automated and must be run manually, as explained in the README in the test/UnitTests folder.