feat(rust/rbac-registration): refactoring #127

stanislav-tkach · 2024-12-30T11:19:56Z

Description

The Cip0134UriSet type was added.
Option<Vec<_>> fields of the Cip509RbacMetadata structure were changed to Vec<_>.
Error handling becomes stricter.
Store x509 certificates (Cip509RbacMetadata::x509_certs) in the decoded format.
Store certificate URIs in the registration chain.
Use types from the cardano-blockchain-types crate.

Related Issue(s)

Closes #104.

Related Pull Requests

This is a combination of the following pull requests:

Please confirm the following checks

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream module

github-actions · 2024-12-30T11:57:48Z

✅ Test Report | ${\color{lightgreen}Pass: 230/230}$ | ${\color{red}Fail: 0/230}$ |

…ed format (#128)

rust/rbac-registration/src/cardano/cip509/mod.rs

bkioshn

LGTM 🌈

rust/rbac-registration/src/cardano/cip509/mod.rs

rust/rbac-registration/src/cardano/cip509/rbac/mod.rs

rust/rbac-registration/src/cardano/cip509/mod.rs

rust/rbac-registration/src/cardano/cip509/utils/cip134/mod.rs

rust/rbac-registration/src/cardano/cip509/utils/cip134/uri_set.rs

rust/rbac-registration/src/cardano/cip509/validation.rs

github-actions · 2025-01-03T22:49:44Z

✅ Test Report | ${\color{lightgreen}Pass: 256/256}$ | ${\color{red}Fail: 0/256}$ |

github-actions · 2025-01-03T22:57:48Z

✅ Test Report | ${\color{lightgreen}Pass: 256/256}$ | ${\color{red}Fail: 0/256}$ |

rust/rbac-registration/Cargo.toml

rust/rbac-registration/src/cardano/cip509/cip509.rs

…into rbac-registration-improvements

rust/rbac-registration/src/cardano/cip509/validation.rs

* test(rbac-registration): fix test and test data Signed-off-by: bkioshn <[email protected]> * fix(rbac-registration): name txn_index Signed-off-by: bkioshn <[email protected]> * fix(rbac-registration): add more test to registration chain Signed-off-by: bkioshn <[email protected]> * test(rbac-registration): fix conway4 block Signed-off-by: bkioshn <[email protected]> * test(rbac-registration): fix conway4 block Signed-off-by: bkioshn <[email protected]> * fix(rbac-registration): consume undefined cbor Signed-off-by: bkioshn <[email protected]> * fix(rbac-registration): format Signed-off-by: bkioshn <[email protected]> * test(rbac-registration): fix conway1 and 4 test data Signed-off-by: bkioshn <[email protected]> --------- Signed-off-by: bkioshn <[email protected]>

github-actions · 2025-01-24T10:58:52Z

✅ Test Report | ${\color{lightgreen}Pass: 271/271}$ | ${\color{red}Fail: 0/271}$ |

Mr-Leshiy

LGTM

github-actions · 2025-01-24T11:10:05Z

✅ Test Report | ${\color{lightgreen}Pass: 271/271}$ | ${\color{red}Fail: 0/271}$ |

github-actions · 2025-01-24T13:17:34Z

✅ Test Report | ${\color{lightgreen}Pass: 271/271}$ | ${\color{red}Fail: 0/271}$ |

github-actions · 2025-01-24T17:15:20Z

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

Introduce Cip0134UriSet type (#119)

6ad8cdc

stanislav-tkach requested review from stevenj and bkioshn December 30, 2024 11:19

stanislav-tkach self-assigned this Dec 30, 2024

stanislav-tkach changed the title ~~feat(rust/rbac-registration):~~ feat(rust/rbac-registration): refactoring Dec 30, 2024

stanislav-tkach added 3 commits December 31, 2024 10:30

Store x509 certificates (Cip509RbacMetadata::x509_certs) in the decod…

0b680c7

…ed format (#128)

Store and update certificate URIs in the registration chain (#130)

c94f142

Merge branch 'main' into rbac-registration-improvements

8298dff

stanislav-tkach marked this pull request as ready for review January 2, 2025 09:49

bkioshn reviewed Jan 3, 2025

View reviewed changes

rust/rbac-registration/src/cardano/cip509/mod.rs Outdated Show resolved Hide resolved

bkioshn previously approved these changes Jan 3, 2025

View reviewed changes

stevenj requested changes Jan 3, 2025

View reviewed changes

stevenj and others added 2 commits January 3, 2025 18:44

Merge branch 'main' into rbac-registration-improvements

78df433

Check for presense of purpose and txn_inputs_hash fields

927da38

stanislav-tkach dismissed bkioshn’s stale review via 927da38 January 3, 2025 22:41

Use Blake2b256Hash type

84137d9

Make Cip509 field private

a5af8a8

stanislav-tkach force-pushed the rbac-registration-improvements branch from 5fad6f6 to a5af8a8 Compare January 3, 2025 23:46

stanislav-tkach marked this pull request as draft January 4, 2025 11:40

stanislav-tkach added 8 commits January 7, 2025 17:35

Merge branch 'main' into rbac-registration-improvements

012601e

Use problem report

800ee5c

More problem report usage in Cip509RbacMetadata

ec483f2

Cip0134Uri::try_from(&[u8])

d9cd7b9

Move addresses extraction to a function

b3be9b0

Move Cip0134Uri to the cardano-blockchain-types crate

2afd1ff

role data as map

de667b7

Role0 constant

fccfe4f

stanislav-tkach added 3 commits January 22, 2025 15:06

Remove unused dependency

5dd995d

Ensure that there is no encryption key for the role 0

2add588

Use the encryption key value in the message

a4335f4

Mr-Leshiy reviewed Jan 23, 2025

View reviewed changes

rust/rbac-registration/Cargo.toml Outdated Show resolved Hide resolved

rust/rbac-registration/src/cardano/cip509/cip509.rs Outdated Show resolved Hide resolved

rust/rbac-registration/src/cardano/cip509/cip509.rs Show resolved Hide resolved

stanislav-tkach added 6 commits January 23, 2025 12:51

Use UuidV4

7214cdc

Remove duplicated check

c7d1aa1

Revert UUID changes (temporary)

8287bc0

Merge branch 'main' into rbac-registration-improvements

596b47d

Update UUID names

fecdd65

Use revision for cbork-utils

81eec3d

This was referenced Jan 23, 2025

feat(rust/catalyst-types): Implement Debug for ProblemReport #173

Merged

feat(rust/cardano-blockchain-types): Move Cip0134Uri to cadrano-blockchain-types #174

Merged

stanislav-tkach added 3 commits January 23, 2025 18:18

Merge branch 'main' into rbac-registration-improvements

5d67b68

Use revisions instead of paths for dependencies

925b539

Merge remote-tracking branch 'origin/rbac-registration-improvements' …

3371497

…into rbac-registration-improvements

bkioshn reviewed Jan 24, 2025

View reviewed changes

rust/rbac-registration/src/cardano/cip509/validation.rs Outdated Show resolved Hide resolved

bkioshn and others added 2 commits January 24, 2025 11:53

Use tag for dependencies

21e6bfc

Update public key at 0 index error message

a43d6ec

Mr-Leshiy approved these changes Jan 24, 2025

View reviewed changes

stanislav-tkach removed the do not merge yet PR is not ready to merge yet label Jan 24, 2025

Merge branch 'main' into rbac-registration-improvements

7c81843

stevenj approved these changes Jan 24, 2025

View reviewed changes

Merge branch 'main' into rbac-registration-improvements

3823a9c

stanislav-tkach merged commit ffe23e3 into main Jan 24, 2025
20 of 22 checks passed

stanislav-tkach deleted the rbac-registration-improvements branch January 24, 2025 17:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rust/rbac-registration): refactoring #127

feat(rust/rbac-registration): refactoring #127

stanislav-tkach commented Dec 30, 2024 •

edited

Loading

github-actions bot commented Dec 30, 2024 •

edited

Loading

bkioshn left a comment

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 24, 2025

Mr-Leshiy left a comment

github-actions bot commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

feat(rust/rbac-registration): refactoring #127

feat(rust/rbac-registration): refactoring #127

Conversation

stanislav-tkach commented Dec 30, 2024 • edited Loading

Description

Related Issue(s)

Related Pull Requests

Please confirm the following checks

github-actions bot commented Dec 30, 2024 • edited Loading

bkioshn left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 3, 2025

github-actions bot commented Jan 24, 2025

Mr-Leshiy left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

stanislav-tkach commented Dec 30, 2024 •

edited

Loading

github-actions bot commented Dec 30, 2024 •

edited

Loading