Handle non-text file gracefully (#7)

insightsengineering · Feb 23, 2022 · 7dea706 · 7dea706 · github-actions · Feb 23, 2022
1 parent a969afd
commit 7dea706
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug.yml b/.github/ISSUE_TEMPLATE/bug.yml
@@ -3,8 +3,6 @@ name: 🐞 Bug Report
 description: File a bug report
 title: "[Bug]: <title>"
 labels: ["bug"]
-assignees:
-  - insightsengineering/idr
 body:
   - type: markdown
     attributes:
@@ -43,7 +41,7 @@ body:
     attributes:
       label: Relevant log output
       description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks.
-      render: python
+      render: Python
   - type: checkboxes
     id: terms
     attributes:

diff --git a/presidio_cli/__init__.py b/presidio_cli/__init__.py
@@ -2,7 +2,7 @@
 
 
 APP_NAME = "presidio_cli"
-APP_VERSION = "0.0.5"
+APP_VERSION = "0.0.6"
 APP_DESCRIPTION = __doc__
 SHELL_NAME = "presidio"
 

diff --git a/presidio_cli/cli.py b/presidio_cli/cli.py
@@ -118,8 +118,11 @@ def find_files_recursively(items, conf):
             for root, dirnames, filenames in os.walk(item):
                 for f in filenames:
                     filepath = os.path.join(root, f)
-                    if conf.is_text_file(filepath):
-                        yield filepath
+                    try:
+                        if conf.is_text_file(filepath):
+                            yield filepath
+                    except UnicodeDecodeError:
+                        pass  # Found non-text data
         else:
             yield item
File	Stmts	Miss	Cover
presidio_cli
init.py	9	0	100%
analyzer.py	47	1	98%
cli.py	146	22	85%
config.py	76	4	95%
TOTAL	278	27	90%