Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: readme revamp #1108

Merged
merged 40 commits into from
Dec 19, 2024
Merged

feat: readme revamp #1108

merged 40 commits into from
Dec 19, 2024

Conversation

sash-a
Copy link
Contributor

@sash-a sash-a commented Oct 23, 2024

What?

Updating the readme and moving the advanced usage to examples.

  • Added per system readme's
  • Mentioned sebulba and sable
  • Updated results (although I'm not convinced we should have all of those, maybe the single aggregated plot)
  • Update roadmap
  • Move installation and quickstart up
  • Added a table of algorithms and environments (not convinced it should be collapsible, have it that way because it seemed like a good idea)

Why?

It is long overdue 😉

closes #1149

@sash-a
Copy link
Contributor Author

sash-a commented Nov 4, 2024

todo: add ruff badge

@sash-a
Copy link
Contributor Author

sash-a commented Nov 8, 2024

todo: add shape legend in docs

Copy link
Collaborator

@arnupretorius arnupretorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks :)

Please see my few suggested changes.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@RuanJohn RuanJohn marked this pull request as ready for review December 13, 2024 06:44
Copy link
Collaborator

@arnupretorius arnupretorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the edits, looking good! 😄

Just one more edit suggestion, please take a look.

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@arnupretorius arnupretorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive effort to get all the changes in over the past weeks! Well done! 🔥

This looks good to me! 😄

@RuanJohn RuanJohn merged commit 4076c7c into develop Dec 19, 2024
3 checks passed
@RuanJohn RuanJohn deleted the feat/readme-revamp branch December 19, 2024 07:53
sash-a added a commit that referenced this pull request Jan 10, 2025
* feat: initial readme revamp

* chore: some readme fixes

* fix: convert images to png

* chore: changes around performance plots in readme

* chore: add more benchmark images

* chore: update images

* chore: rename legend

* chore: add legend to readme

* chore: move install + getting started near the top

* feat: update system readmes

* chore: a note on ISAC

* chore: update branch naming convention doc

* chore: some readme updates

* feat: switch detailed install instruction to uv

* docs: python badge

* wip: system level docs

* feat: readme badges

* chore: add speed plot and move tables out of collapsible

* fix: run pre commits

* fix: tests budge link

* feat: system level configs

* chore: github math render fix

* chore: github math render fix and linting

* docs: add links to system readmes, papers and hydra

* docs: qlearning paper links

* docs: reword sebulba section to be distribution architectures

* docs: change reference to sable paper

* docs: clarify distribution architectures that are support for different envs

* docs: general spelling mistake fixes and relative links to docs and files

* docs: typo fixes

* docs: replace absolute website links with relative links

* docs: sable diagram caption

* docs: sable caption math

* docs: another sable diagram caption fix

* docs: sable diagram math render

* docs: add environment code and paper links

---------

Co-authored-by: RuanJohn <[email protected]>
Co-authored-by: OmaymaMahjoub <[email protected]>
Co-authored-by: Ruan de Kock <[email protected]>
sash-a added a commit that referenced this pull request Jan 10, 2025
* feat: initial readme revamp

* chore: some readme fixes

* fix: convert images to png

* chore: changes around performance plots in readme

* chore: add more benchmark images

* chore: update images

* chore: rename legend

* chore: add legend to readme

* chore: move install + getting started near the top

* feat: update system readmes

* chore: a note on ISAC

* chore: update branch naming convention doc

* chore: some readme updates

* feat: switch detailed install instruction to uv

* docs: python badge

* wip: system level docs

* feat: readme badges

* chore: add speed plot and move tables out of collapsible

* fix: run pre commits

* fix: tests budge link

* feat: system level configs

* chore: github math render fix

* chore: github math render fix and linting

* docs: add links to system readmes, papers and hydra

* docs: qlearning paper links

* docs: reword sebulba section to be distribution architectures

* docs: change reference to sable paper

* docs: clarify distribution architectures that are support for different envs

* docs: general spelling mistake fixes and relative links to docs and files

* docs: typo fixes

* docs: replace absolute website links with relative links

* docs: sable diagram caption

* docs: sable caption math

* docs: another sable diagram caption fix

* docs: sable diagram math render

* docs: add environment code and paper links

---------

Co-authored-by: RuanJohn <[email protected]>
Co-authored-by: OmaymaMahjoub <[email protected]>
Co-authored-by: Ruan de Kock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MAINTAIN] Review of Mava vs JaxMARL SMAX Results
4 participants