Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Type ignore on max_length_time_axis #35

Merged
merged 16 commits into from
Jul 26, 2024

Conversation

callumtilbury
Copy link
Contributor

In the trajectory buffers (normal and prioritised), mypy is unhappy with max_length_time_axis, because it thinks it may be a None. If you follow the control flow, it won't ever be None, but using any of the other mypy changes (e.g. a "cast") will make the code messier, I believe. Simpler, here, to use the type ignore.

Copy link
Contributor

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could possibly use an assert instead but I think it's fine to just ignore in this case. 🥇

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ callumtilbury
❌ vikranth-t
You have signed the CLA already but the status is still pending? Let us recheck it.

@callumtilbury callumtilbury merged commit 780183f into main Jul 26, 2024
4 of 5 checks passed
@callumtilbury callumtilbury deleted the chore/mypy-max-len-time-axis branch July 26, 2024 15:38
callumtilbury added a commit that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants