-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Type ignore on max_length_time_axis #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could possibly use an assert
instead but I think it's fine to just ignore in this case. 🥇
|
In the trajectory buffers (normal and prioritised), mypy is unhappy with
max_length_time_axis
, because it thinks it may be aNone
. If you follow the control flow, it won't ever beNone
, but using any of the other mypy changes (e.g. a "cast") will make the code messier, I believe. Simpler, here, to use the type ignore.