Create test helpers and reset mocks before each test #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @int128, Quick PR here on tests, I have another PR after this for region support also if you are interested? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Whilst working on adding region support for #883 I found I was making a lot of changes to existing tests.
To reduce the size of that upcoming PR I thought I should split out this smaller change to:
.on()and.resolves()because why notNotes
I currently just import the
helpers.tsfile in the test files. However, we could use jest helpers and create atsconfig.test.json, etc. if we wanted to go that way. Seemed to big a change for a first contribution. See https://stackoverflow.com/a/52910794.