Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] BUGFIX: Creating thread to monitor ptp4l alive status #98

Open
wants to merge 151 commits into
base: main
Choose a base branch
from

Conversation

AzuraTarmiziIntel
Copy link
Contributor

Issue raised :
#92

The solution is to create a monitoring_thread to monitor the liveliness of ptp4l.

Noor Azura Ahmad Tarmizi and others added 30 commits May 16, 2024 11:51
Add upper and lower limits for threshold

Fix name (SPC->'.') of client side message queue and add unlinking in finalize to cleanup queue
This document will provide basic architecture and simplified code flow
for connect/subscribe/notification messages.

This is a live document.

Signed-off-by: Noor Azura Ahmad Tarmizi <[email protected]>
Add workflow to build the code using coverity tool and upload the result to
https://scan.coverity.com/builds?project=libptpmgmt_iaclocklib.

The workflow will run automatically when new changes are pushed to main
branch.

Signed-off-by: Song Yoong Siang <[email protected]>
Add workflow for security vulnerabilities scan and upload the result to
https://securityscorecards.dev/viewer/?uri=github.com/intel-staging/libptpmgmt_iaclocklib

The workflow will run automatically when new changes are pushed to main
branch.

Signed-off-by: Song Yoong Siang <[email protected]>
1. In GitHub action:
    - set permissions as read
    - add Harden Runner
    - use SHA commit id instead of version
2. Add codeql scanning

Signed-off-by: StepSecurity Bot <[email protected]>
Replace autobuild command with proper build steps

Signed-off-by: Song Yoong Siang <[email protected]>
Try to point to erezgeva container as we dint plan to
create our own image.

Signed-off-by: Song Yoong Siang <[email protected]>
The connect message now will return the client session ID to the client.
It will also have the timeout of 5 sec by default to receive the proxy
reply.

This could be change in the future.

Signed-off-by: Noor Azura Ahmad Tarmizi <[email protected]>
The virus scan will be run for every PR agaist master branch
and whenever master branch got changes.

Signed-off-by: Song Yoong Siang <[email protected]>
Add two new subscribe events:
  1. NOTIFY_PORT_STATE_NP
  2. NOTIFY_ALL

Signed-off-by: Song Yoong Siang <[email protected]>
This document is created for clock manager installation and test guidance reference.
Can be used by user and validation alike.

This is a work in progress.
Signed-off-by: Noor Azura Ahmad Tarmizi <[email protected]>
Execute the script with "sh ./run_ptp4l.sh" and start ptp4l program.

Signed-off-by: Lai Peter Jun Ann <[email protected]>
Added subscription message tx and rx pathway between the proxy and client.

Signed-off-by: Noor Azura Ahmad Tarmizi <[email protected]>
Signed-off-by: Noor Azura Ahmad Tarmizi <[email protected]>
When Proxy receive subscription message, send
the initial state of PTP back to Client.
Client will parse the data and print it out.

Signed-off-by: Song Yoong Siang <[email protected]>
…proxy sub msg

This is to ensure the whole message with the data :

Msgid, msgack, jcl_subscription, ptp_event struct are sent by the proxy and
received correctly by the Client.

Signed-off-by: Noor Azura Ahmad Tarmizi <[email protected]>
Proxy will send notification message to client to report
the latest data it received from ptp4l.

Signed-off-by: Song Yoong Siang <[email protected]>
This commit removes the less -R command from the default target in the
Makefile of client, common and proxy.

The less -R command was originally used to paginate the output of the make
command. However, this caused an issue where the build process would pause
until the user manually quit less by pressing "q".

This is not a typical or recommended use of less, especially in a Makefile.
less is designed for interactive use in a shell to view the contents of a
file or the output of a command page by page. In a Makefile, it can cause
problems if the Makefile is run in a non-interactive environment where
there's no user to scroll through the pages.

Signed-off-by: Song Yoong Siang <[email protected]>
Will add back when we figure out why we need it.

Signed-off-by: Song Yoong Siang <[email protected]>
Lai Peter Jun Ann and others added 2 commits June 27, 2024 15:39
Issue raised :
#92

The solution is to create a monitoring_thread to monitor the liveliness of
ptp4l.

Signed-off-by: Noor Azura Ahmad Tarmizi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants