Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project #3

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Update project #3

wants to merge 12 commits into from

Conversation

Tokarak
Copy link

@Tokarak Tokarak commented Jun 1, 2022

With IntrepidusGroup mysteriously disappearing into thin air, the gitbucket mirror is down. This mainly updates those links to Github. Other changes include:

  • stops at errors: much safer to run
  • updating is prompted to be done manually through git
  • changed old tools to new where possible (eg using pip)
  • small optimisations and safety checks

I doubt this will get merged, so I urge anyone reading this to use my fork of the script instead of the one which will be cloned by git when you install.

It is better to use no script at all, as the install structure is somewhat messy; have a look at what apt installs in the file (don't forget the one line where pip is used), and clone this repo manually. This also allows you to find equivalent packages in other distributions (eg Arch).

The latest Ubuntu LTS (20.04 Focal at the time of writing) lacks some of the required packages. I managed to successfully install the dependencies on 18.04 Bionic. Check which packages are available on https://packages.ubuntu.com.

@RajUmadas
Copy link

whoaoooo blast from the past. i wonder how we can even merge this stuff in now.

@Tokarak
Copy link
Author

Tokarak commented Jun 1, 2022

Well, its mergable, but I am trying to fix some more python dependencies, because I am getting an error. I am trying to fix it up, and updating my fork at the same time; then you can merge, or it can remain as my own fork.

Since you are here, do you know of a modern alternative? Maybe sensepost/mallet?

* Error handling for import of http_plugin_manager continues on error but in __main__ script attempts to use http_plugin_manager that may not be imported. This change checks if http_plugin_manager is imported

* Added more verbose error messages to aid debugging.

Co-authored-by: Josh Dukes <[email protected]>
@Tokarak Tokarak changed the title Fix mallory_install.sh Update project Jun 1, 2022
Tokarak added 2 commits June 1, 2022 17:40
Pillow, IPy installed through APT
@Tokarak Tokarak force-pushed the master branch 2 times, most recently from e12135b to 4861ba2 Compare June 1, 2022 17:18
'Import Image' was long ago deprecated, and now is invalid syntax. Updated all cases referenced by mallory.py.
@Tokarak Tokarak marked this pull request as draft June 1, 2022 17:20
@Tokarak
Copy link
Author

Tokarak commented Jun 1, 2022

This point marks correct non-gui operation.

@cweedon
Copy link

cweedon commented Jun 1, 2022

As much as I love a good blast from the past, it might be best to let this one die. It's been over a decade since IG ceased to exist, and we never bothered for python3 compatibility when mallory was written

@Tokarak
Copy link
Author

Tokarak commented Jun 1, 2022

Then I need an alternative tool. I am also debugging the gui, and thats good for my education if nothing else.

@Tokarak
Copy link
Author

Tokarak commented Jun 2, 2022

Turns out, I didn't think to start a mallory session before starting the gui 🥲. Consider this project resurrected and mergeable, unless some functionality is broken.

@Tokarak Tokarak marked this pull request as ready for review June 2, 2022 13:06
@RajUmadas
Copy link

@Tokarak I have to agree with @cweedon. Intrepidus Group as a company was a great great place, but many of the folks who worked on this project are not longer working for the org that has acquired IG. That being said, seeing activity here is really near and dear to my heart, as the guts of mallory and its v0 was my main project during my first year as an infosec professional.

I would recommend that you fork this project out and continue to work on it in an org all of your own. Unless someone who still works at NCC wants to resueruct this project and manage this GH org.

I would also offer that me and you sync up on a google hangout/zoom so i can brain dump LOTs of mallory stuff. It should make your digging more productive. What timezone are you in?

@Tokarak
Copy link
Author

Tokarak commented Jun 2, 2022

@RajUmadas It looks like nobody has write access to this repo; I will close this pr and continue any developments on my fork.

I would love to learn more about this project, but you should at least know I am just a kid on half term break who is doing all of this to cheat in a mobile game; If that's ok with you, you can contact me on [email protected].

Tokarak added 2 commits June 3, 2022 20:36
Fixs the same bug as previous commit which went unnoticed.
The old script depended too heavily on it running smoothly - unlikely, when run on a modern Linux distribution.
This script now only installs the dependencies and gives helpful information to the user;
updating the repo should be done manually through git pull.
Overall: easier to debug, safer to run, less junk files generated.
@Tokarak
Copy link
Author

Tokarak commented Jun 4, 2022

@RajUmadas does the Mallory program require root privileges? In both mallory.py and launchgui.py? Is the program safe to run as root, or should I add the deprecated gksudo to the dependencies?

Tokarak added 4 commits June 7, 2022 11:56
Removed a "try" clause when modifying iptables.
Credit: RajUmadas on the CarveSystems/Mallory fork
ivision-research/Mallory@3ec5110
If mallory crashes, launchgui would start while-True-ing error messages;

This should also make clear the annoying scenario new users face when they try to run the gui without mallory. That should go in the README someday soon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants