bcc: Replace deprecated libbpf API #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhengqi
requested review from
drzaeus77,
yonghong-song,
4ast and
davemarchevsky
as code owners
anakryiko
reviewed
Apr 11, 2022
| @@ -1554,7 +1554,7 @@ int bpf_attach_xdp(const char *dev_name, int progfd, uint32_t flags) { | |||
| return -1; | |||
| } | |||
|
|
|||
| ret = bpf_set_link_xdp_fd(ifindex, progfd, flags); | |||
| ret = bpf_xdp_attach(ifindex, progfd, flags, NULL); | |||
There was a problem hiding this comment.
is this the only legacy API that BCC uses in its entire code base?
Replace deprecated libbpf API bpf_set_link_xdp_fd with bpf_xdp_attach. Signed-off-by: Hengqi Chen <[email protected]>
Replace deprecated libbpf API bpf_map__resize with bpf_map__set_max_entries. Signed-off-by: Hengqi Chen <[email protected]>
chenhengqi
force-pushed
the
fix-deprecation
branch
from
d01c033 to
7e5dcda
Compare
anakryiko
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hengqi Chen [email protected]