Skip to content

Commit

Permalink
Merge pull request #506 from fsdiogo/fix/icons-hover
Browse files Browse the repository at this point in the history
This PR fixes a problem that happened in Chrome (Mac). 

As we hovered the icons they scaled a bit so it had a weird behaviour:
![before](https://user-images.githubusercontent.com/33324750/42035793-adde7dce-7adb-11e8-9de0-3297f0b7dadd.gif)

I've removed the scale effect, as it was minor and the changing background color is more than sufficient from an UX point of view:
![after](https://user-images.githubusercontent.com/33324750/42035797-b02e0e00-7adb-11e8-9368-6bc43f93133f.gif)
  • Loading branch information
lidel authored Jun 28, 2018
2 parents 87d7dbc + ca9bca8 commit 250e933
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion add-on/src/popup/browser-action/icon.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const browser = require('webextension-polyfill')

function icon ({ svg, title, active, action }) {
return html`
<button class="pa0 ma0 dib bn bg-transparent pointer grow transition-all ${active ? 'fill-aqua hover-fill-snow' : 'fill-gray hover-fill-snow-muted'}"
<button class="pa0 ma0 dib bn bg-transparent pointer transition-all ${active ? 'fill-aqua hover-fill-snow' : 'fill-gray hover-fill-snow-muted'}"
style="outline:none;"
title="${browser.i18n.getMessage(title)}"
onclick=${action}>
Expand Down

0 comments on commit 250e933

Please sign in to comment.