-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardizing all actions #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxsnq
reviewed
Apr 19, 2024
Change merge strategy to squash, so we would have beautiful branch history in main |
MatthewZMSU
commented
May 3, 2024
mxsnq
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As we fixed CustomJsAction response in the JavaScript part, we do not need search through the all attributes of Response.
We introduce new
PuppeteerRecaptchaSolverResponse
.This will increase performance and readability.
Also applied black formatting for several .py files.
For backward compatibility we left
self.data
attribute ofPuppeteerRecaptchaSolverResponse
. But we marked this as deprecated.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This has been tested on my local PC with several Scrapy spiders.
Checklist: