Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizing all actions #26

Merged
merged 11 commits into from
May 29, 2024
Merged

Standardizing all actions #26

merged 11 commits into from
May 29, 2024

Conversation

MatthewZMSU
Copy link
Contributor

@MatthewZMSU MatthewZMSU commented Mar 22, 2024

Description

As we fixed CustomJsAction response in the JavaScript part, we do not need search through the all attributes of Response.
We introduce new PuppeteerRecaptchaSolverResponse.
This will increase performance and readability.
Also applied black formatting for several .py files.
For backward compatibility we left self.data attribute of PuppeteerRecaptchaSolverResponse. But we marked this as deprecated.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

How Has This Been Tested?

This has been tested on my local PC with several Scrapy spiders.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@MatthewZMSU MatthewZMSU changed the title Extra attributes search Standardizing all actions May 3, 2024
@MatthewZMSU
Copy link
Contributor Author

Change merge strategy to squash, so we would have beautiful branch history in main

@mxsnq mxsnq merged commit b23cf9a into ispras:master May 29, 2024
7 checks passed
@MatthewZMSU MatthewZMSU deleted the MZ_extra_attrs branch May 30, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants