add label selector to DestinationRule subset config #3397
Conversation
istio-testing
added
the
do-not-merge/work-in-progress
|
😊 Welcome @shulin-sq! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
istio-testing
added
size/M
|
Hi @shulin-sq. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -337,6 +337,8 @@ message Subset { | |||
| // specified at the subset level will override the corresponding settings | |||
| // specified at the DestinationRule level. | |||
| TrafficPolicy traffic_policy = 3; | |||
|
|
|||
| istio.type.v1beta1.LabelSelector selector = 4; | |||
There was a problem hiding this comment.
add some ducuments, what is the relationship with labels field
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
istio-testing
added
the
needs-rebase
No description provided.