-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata fallback for client sidecar reporters #6028
base: master
Are you sure you want to change the base?
Add metadata fallback for client sidecar reporters #6028
Conversation
Long term, I need to see if I can create a lasso of ssl contexts so we don't need WDS fallback for peer principal. I recall @kyessenov saying it's possible, and the way we get http status codes may be a clue |
is this covered by a test? |
Ah forgot to add one in the flurry of PRs; will do |
Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
cc05bcd
to
28df9a0
Compare
Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
@keithmattix: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it: Companion to istio/istio#54383. Use MX fallback if there's no ssl context for the upstream connection (there won't be when we're doing CONNECT encap due to the extra internal listener in between). Note that this doesn't help with the source principal; we may be able to set some filter state in the connect_encap listener and have stats read it before we flush, but I'd need to try it out.