Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata fallback for client sidecar reporters #6028

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

keithmattix
Copy link
Contributor

What this PR does / why we need it: Companion to istio/istio#54383. Use MX fallback if there's no ssl context for the upstream connection (there won't be when we're doing CONNECT encap due to the extra internal listener in between). Note that this doesn't help with the source principal; we may be able to set some filter state in the connect_encap listener and have stats read it before we flush, but I'd need to try it out.

@keithmattix keithmattix requested a review from a team as a code owner December 28, 2024 00:59
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 28, 2024
@keithmattix
Copy link
Contributor Author

Long term, I need to see if I can create a lasso of ssl contexts so we don't need WDS fallback for peer principal. I recall @kyessenov saying it's possible, and the way we get http status codes may be a clue

@keithmattix keithmattix requested a review from zirain December 31, 2024 19:01
@zirain
Copy link
Member

zirain commented Jan 3, 2025

is this covered by a test?

@keithmattix
Copy link
Contributor Author

is this covered by a test?

Ah forgot to add one in the flurry of PRs; will do

@keithmattix keithmattix added cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch cherrypick/release-1.24 Set this label on a PR to auto-merge it to the release-1.24 branch labels Jan 6, 2025
@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
@keithmattix keithmattix force-pushed the client-sidecar-metadata-fallback branch from cc05bcd to 28df9a0 Compare January 8, 2025 01:08
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Jan 8, 2025
Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
@istio-testing
Copy link
Collaborator

@keithmattix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test-arm-arm64_proxy df1c0b7 link true /test test-arm-arm64
test-asan_proxy df1c0b7 link true /test test-asan
test_proxy df1c0b7 link true /test test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch cherrypick/release-1.24 Set this label on a PR to auto-merge it to the release-1.24 branch size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants