JSON file abstraction improvements #2344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone.
This PR improves the abstraction of JSON objects (files), as it is currently very limited and if there are null values it is very difficult (cumbersome) to deal with as it does not provide mechanisms to identify it.
Also in this PR topic #2316 (implementation of method to identify the type of element) is addressed, since this topic is closely linked to the objective of this PR (which is to improve said abstraction) and is included in it,
At the moment, as far as I know, these changes don't break anything (especially the GLTF loader, in my tests everything works)
What do you think of these changes?