don't allow bounding scale for marker to be too large #644
+42
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neph1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what has happened here, must be a regression of some sort.
I noticed when creating a skybox (during) that it threw an error. This also occurs when selecting a node which contains a skybox.
The cause is that the skybox has an infinite bound (naturally), this is propagated to the node, which tries to set the tool marker scale to be the same as the bounds of the node. This throws an assert error about inifite scale.
I've limited the scale to 100, and it will set it to 1 if it exceeds that. This is arbitrary.