Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Dockerfile #759

Closed
wants to merge 2 commits into from
Closed

Working Dockerfile #759

wants to merge 2 commits into from

Conversation

Helvio88
Copy link
Contributor

This is a working Dockerfile. It can be built with docker build -t memegen . and ran by issuing docker run --rm -p 5000:5000 memegen then opening your browser at http://localhost:5000

This is by far not all that's needed, but it's a start – and it's not exactly dependent on any other code or documentation, since there's nothing as of now on how to run the code.

If this gets accepted, I'll try my best to include ENV vars and Documentation on how to run it.
Might also assist with GH Actions to auto publish to dockerhub.

@jacebrowning
Copy link
Owner

How is this different from or better than the Containerfile documented here?

@Helvio88
Copy link
Contributor Author

I guess I just expected to see the container file names Dockerfile, making this redundant. Thanks for pointing those 2 files out.

@Helvio88 Helvio88 closed this Dec 14, 2022
@Helvio88
Copy link
Contributor Author

FYI I have set up an auto-updating (latest only) dockerhub image for this repository, without changes. Please see helvio/memegen. If you would like me to take it down, please let me know. I have built it for personal use, really, but could be used by more people if endorsed by you.

@jacebrowning
Copy link
Owner

Thanks! I'm not ready to add that to the documentation, but feel free to mention it here: #726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants