Fix race condition on sendCommand.js #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a real-world problem with avrgirl-arduino, which depends on this library, it turns out that, this library subscribes to receive data only after sending data to the board, on slower computers, this makes the board sends the response before the library starts listening to data, which makes the library lose the transmission and trigger a timeout error. The change passed on the unit test, and I've successfully uploaded the blink sketch to an Arduino Uno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a real-world problem with avrgirl-arduino, which depends on this library, it turns out that, this library subscribes to receive data only after sending data to the board, on slower computers, this makes the board sends the response before the library starts listening to data, which makes the library lose the transmission and trigger a timeout error.
The change passed on the unit test, and I've successfully uploaded the blink sketch to an Arduino Uno