Use type for encoding

Signed-off-by: Pavol Loffay <[email protected]>
jaegertracing · Jul 16, 2021 · 4c545fc · 4c545fc
1 parent 49bda9e
commit 4c545fc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/storage/config.go b/storage/config.go
@@ -2,6 +2,13 @@ package storage
 
 import "time"
 
+type EncodingType string
+
+const (
+	JsonEncoding     EncodingType = "json"
+	ProtobufEncoding EncodingType = "protobuf"
+)
+
 type Configuration struct {
 	// ClickHouse address e.g. tcp://localhost:9000.
 	Address string `yaml:"address"`
@@ -12,5 +19,5 @@ type Configuration struct {
 	// Batch flush interval. Default is 5s.
 	BatchFlushInterval time.Duration `yaml:"batch_flush_interval"`
 	// Encoding either json or protobuf. Default is json.
-	Encoding string `yaml:"encoding"`
+	Encoding EncodingType `yaml:"encoding"`
 }
diff --git a/storage/store.go b/storage/store.go
@@ -52,7 +52,7 @@ func NewStore(logger hclog.Logger, cfg Configuration, embeddedSQLScripts embed.F
 		cfg.BatchFlushInterval = defaultBatchDelay
 	}
 	if cfg.Encoding == "" {
-		cfg.Encoding = string(clickhousespanstore.EncodingJSON)
+		cfg.Encoding = JsonEncoding
 	}
 	return &Store{
 		db:     db,