Updated react-icons and antd version #2595
Conversation
Signed-off-by: coderboy-yash <[email protected]>
Signed-off-by: coderboy-yash <[email protected]>
coderboy-yash
requested review from
albertteoh
and removed request for
a team
| @@ -22,7 +22,7 @@ | |||
| "eslint-plugin-jsx-a11y": "^6.8.0", | |||
| "eslint-plugin-react": "7.37.1", | |||
| "husky": "9.1.0", | |||
| "jsdom": "25.0.1", | |||
| "jsdom": "^26.0.0", | |||
There was a problem hiding this comment.
how is this related to ant/icons upgrade?
There was a problem hiding this comment.
how is this related to ant/icons upgrade?
no this is not related to ant/icons update , actually I made a pr to the issue #2584 previous to this issue and after that I made this pr so those changes also get included to this pr .
My mistake:- I made changes in the same code for every pr.
I am removing this mistake and will correct this pr soon.
| @@ -65,5 +65,10 @@ | |||
| "hooks": { | |||
| "pre-commit": "npm-run-all -ln --parallel lint test" | |||
| } | |||
| }, | |||
| "dependencies": { | |||
There was a problem hiding this comment.
what is the reason for adding these as top level dependencies?
There was a problem hiding this comment.
these are added by miskake at the top level , these had to be added in the jaeger UI of packages folder.
| @@ -13,7 +13,7 @@ | |||
| // limitations under the License. | |||
|
|
|||
| import React from 'react'; | |||
| import { LuLoader2 } from 'react-icons/lu'; | |||
| import { LuLoader } from 'react-icons/lu'; | |||
There was a problem hiding this comment.
this is icons change, why is it bundled with antd upgrade?
There was a problem hiding this comment.
Previously I merged the changes of antd and react-icons together but after reading your comment I thought you want to do it separately now I have made another pr for this, which handles only react-icons version update.
#2603 you can check this I have resolved all the errors that you mentioned here.
Please let me know if you want to make any other changes to this.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test