Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BreakableText]: Replace defaultProps with destructuring #2619

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

its-me-abhishek
Copy link
Contributor

@its-me-abhishek its-me-abhishek commented Jan 24, 2025

Which problem is this PR solving?

Description of the changes

  • Removed defaultProps and updated the snapshots for the BreakableText component

How was this change tested?

  • By running npm run update-snapshots

Checklist

Partially Resolves jaegertracing#2596
- Remove defaultProps and updated the snapshots for the same

Signed-off-by: Abhishek <[email protected]>
@its-me-abhishek its-me-abhishek requested a review from a team as a code owner January 24, 2025 06:34
@its-me-abhishek its-me-abhishek requested review from mahadzaryab1 and removed request for a team January 24, 2025 06:34
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (2d880b4) to head (ce50891).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2619   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         255      255           
  Lines        7738     7738           
  Branches     1988     1938   -50     
=======================================
  Hits         7476     7476           
  Misses        262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants