Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TraceHeader]: Replace defaultProps with destructuring #2621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

its-me-abhishek
Copy link
Contributor

@its-me-abhishek its-me-abhishek commented Jan 24, 2025

Which problem is this PR solving?

Description of the changes

  • Remove defaultProps from the component, replace with destructuring

How was this change tested?

  • By npm run test, npm run update-snapshots

Checklist

Partially Resolves jaegertracing#2596
- Remove defaultProps from the component, replace with destructuring

Signed-off-by: Abhishek <[email protected]>
@its-me-abhishek its-me-abhishek requested a review from a team as a code owner January 24, 2025 07:04
@its-me-abhishek its-me-abhishek requested review from joe-elliott and removed request for a team January 24, 2025 07:04
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.60%. Comparing base (2d880b4) to head (49443a3).

Files with missing lines Patch % Lines
...mponents/TraceDiff/TraceDiffHeader/TraceHeader.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2621      +/-   ##
==========================================
- Coverage   96.61%   96.60%   -0.02%     
==========================================
  Files         255      255              
  Lines        7738     7736       -2     
  Branches     1988     2005      +17     
==========================================
- Hits         7476     7473       -3     
- Misses        262      263       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant