Skip to content

Commit

Permalink
Completely remove "grpc-plugin" as storage type (#5741)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Last part of #4647
- In accordance with our deprecation policy, this CLI value can be
removed in v1.60 (next release)

## Description of the changes
- No longer accept `grpc-plugin` as a storage type. The valid value is
`grpc`.

Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
yurishkuro authored Jul 14, 2024
1 parent e3e763c commit 023d46e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
1 change: 0 additions & 1 deletion plugin/storage/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ const (
memoryStorageType = "memory"
kafkaStorageType = "kafka"
grpcStorageType = "grpc"
grpcPluginDeprecated = "grpc-plugin"
badgerStorageType = "badger"
blackholeStorageType = "blackhole"

Expand Down
7 changes: 0 additions & 7 deletions plugin/storage/factory_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,6 @@ func FactoryConfigFromEnvAndCLI(args []string, log io.Writer) FactoryConfig {
if spanStorageType == "" {
spanStorageType = cassandraStorageType
}
if spanStorageType == grpcPluginDeprecated {
fmt.Fprintf(log,
"WARNING: `%s` storage type is deprecated and will be remove from v1.60. Use `%s`.\n\n",
grpcPluginDeprecated, grpcStorageType,
)
spanStorageType = grpcStorageType
}
spanWriterTypes := strings.Split(spanStorageType, ",")
if len(spanWriterTypes) > 1 {
fmt.Fprintf(log,
Expand Down

0 comments on commit 023d46e

Please sign in to comment.