Skip to content

Commit

Permalink
Resolve conflicts
Browse files Browse the repository at this point in the history
Signed-off-by: FlamingSaint <[email protected]>
  • Loading branch information
FlamingSaint committed Jul 8, 2024
1 parent 118c8fb commit 44f2627
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions cmd/jaeger/internal/extension/jaegerstorage/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,7 @@ func (cfg *MetricBackends) Unmarshal(conf *confmap.Conf) error {
// apply defaults
if conf.IsSet("prometheus") {
cfg.Prometheus = &prometheus.Options{
Primary: prometheus.NamespaceConfig{
Configuration: prometheus.DefaultConfig(),
},
Configuration: prometheus.DefaultConfig(),

Check warning on line 112 in cmd/jaeger/internal/extension/jaegerstorage/config.go

View check run for this annotation

Codecov / codecov/patch

cmd/jaeger/internal/extension/jaegerstorage/config.go#L110-L112

Added lines #L110 - L112 were not covered by tests
}
// TODO: Need to implement this, Need to add prometheus as a v2 storage ??
}
Expand Down
2 changes: 1 addition & 1 deletion plugin/metrics/prometheus/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func DefaultConfig() config.Configuration {
}

// NewOptions creates a new Options struct.
func NewOptions(primaryNamespace string) *Options {
func NewOptions() *Options {
defaultConfig := DefaultConfig()

return &Options{
Expand Down

0 comments on commit 44f2627

Please sign in to comment.