Skip to content

Commit

Permalink
[ci] Fix binary-size-check workflow (#6552)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Fix for one issue caused in #6527 

## Description of the changes
- cache_output not being set after a cache hit using restore key
- Instead check for cache-matched-key != ''" 

## How was this change tested?
- 

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

Signed-off-by: chahatsagarmain <[email protected]>
  • Loading branch information
chahatsagarmain authored Jan 17, 2025
1 parent 4745045 commit c36d588
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci-lint-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ jobs:
jaeger_binary_size
- name: Compare jaeger binary sizes
if: steps.cache-binary-size.outputs.cache-hit == 'true'
if: steps.cache-binary-size.outputs.cache-matched-key != ''
run: |
OLD_BINARY_SIZE=$(cat ./jaeger_binary_size.txt)
NEW_BINARY_SIZE=$(cat ./new_jaeger_binary_size.txt)
Expand Down

0 comments on commit c36d588

Please sign in to comment.