-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] move root span handler into aggregator #5478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pushkarm029 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5478 +/- ##
==========================================
+ Coverage 95.52% 95.53% +0.01%
==========================================
Files 331 330 -1
Lines 16155 16156 +1
==========================================
+ Hits 15432 15435 +3
+ Misses 548 547 -1
+ Partials 175 174 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: pushkarm029 <[email protected]>
Signed-off-by: pushkarm029 <[email protected]>
yurishkuro
reviewed
May 24, 2024
yurishkuro
reviewed
May 24, 2024
yurishkuro
reviewed
May 24, 2024
yurishkuro
reviewed
May 24, 2024
Pushkarm029
changed the title
Refactor
Implement the logic of May 25, 2024
handleRootSpan
logic into a helper functionhandleRootSpan
into an aggregator function.
Signed-off-by: pushkarm029 <[email protected]>
Signed-off-by: pushkarm029 <[email protected]>
yurishkuro
reviewed
May 25, 2024
Signed-off-by: pushkarm029 <[email protected]>
Pushkarm029
changed the title
Implement the logic of
Refactor the logic of May 26, 2024
handleRootSpan
into an aggregator function.handleRootSpan
into an aggregator function.
yurishkuro
changed the title
Refactor the logic of
[refactor] move root span handler into aggregator
May 26, 2024
handleRootSpan
into an aggregator function.
varshith257
pushed a commit
to varshith257/jaeger
that referenced
this pull request
Jun 2, 2024
## Which problem is this PR solving? - jaegertracing#5389 (comment) ## Description of the changes - Refactored `handleRootSpan` logic into a helper method in aggregator.go. Signed-off-by: Vamshi Maskuri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
remotesampling
extension #5389 (comment)Description of the changes
handleRootSpan
logic into a helper method in aggregator.go.How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test