Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SPM in Jaeger v2 #5681

Merged
merged 71 commits into from
Jul 24, 2024

Increase coverage

8f0ee2b
Select commit
Loading
Failed to load commit list.
Merged

Enable SPM in Jaeger v2 #5681

Increase coverage
8f0ee2b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 22, 2024 in 0s

96.59% (target 95.00%)

View this Pull Request on Codecov

96.59% (target 95.00%)

Details

Codecov Report

Attention: Patch coverage is 84.52381% with 13 lines in your changes missing coverage. Please review.

Project coverage is 96.59%. Comparing base (6bd7aea) to head (8f0ee2b).
Report is 1 commits behind head on main.

Files Patch % Lines
...md/jaeger/internal/extension/jaegerquery/server.go 69.23% 3 Missing and 1 partial ⚠️
...eger/internal/extension/jaegerstorage/extension.go 91.66% 2 Missing and 2 partials ⚠️
pkg/prometheus/config/config.go 0.00% 3 Missing ⚠️
plugin/metrics/prometheus/factory.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5681      +/-   ##
==========================================
- Coverage   96.67%   96.59%   -0.08%     
==========================================
  Files         341      342       +1     
  Lines       16451    16515      +64     
==========================================
+ Hits        15904    15953      +49     
- Misses        360      370      +10     
- Partials      187      192       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov