Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fake import to ensure delve dependency is kept #5857

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Aug 17, 2024

Follow-up fix for #5852 and #5850

@renovate-bot renovate-bot requested a review from a team as a code owner August 17, 2024 18:02
@forking-renovate forking-renovate bot added the changelog:dependencies Update to dependencies label Aug 17, 2024
@dosubot dosubot bot added the go label Aug 17, 2024
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.79%. Comparing base (2931a01) to head (c1e8d3c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5857      +/-   ##
==========================================
- Coverage   96.81%   96.79%   -0.02%     
==========================================
  Files         342      342              
  Lines       16522    16522              
==========================================
- Hits        15995    15993       -2     
- Misses        340      341       +1     
- Partials      187      188       +1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.81% <ø> (ø)
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.74% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.74% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.83% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v1 19.02% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.81% <ø> (+0.01%) ⬆️
grpc_v1 9.52% <ø> (ø)
grpc_v2 7.13% <ø> (-0.02%) ⬇️
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.81% <ø> (+0.01%) ⬆️
memory_v2 1.81% <ø> (ø)
opensearch-1.x-v1 18.89% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 18.89% <ø> (ø)
opensearch-2.x-v2 1.81% <ø> (ø)
unittests 95.27% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro changed the title Update module github.com/go-delve/delve to v1.23.0 Add fake import to ensure delve dependency is kept Aug 17, 2024
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro enabled auto-merge (squash) August 17, 2024 18:43
@yurishkuro yurishkuro disabled auto-merge August 17, 2024 18:55
@yurishkuro yurishkuro merged commit 93ecc9e into jaegertracing:main Aug 17, 2024
43 checks passed
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 28, 2024
Follow-up fix for jaegertracing#5852 and jaegertracing#5850

---------

Signed-off-by: Mend Renovate <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Jared Tan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:dependencies Update to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants