Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/cleanup makefile #5908

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Aug 31, 2024

  • extract Docker, BuildBinaries, and IntegrationTest targets from the main Makefile into dedicated include files
  • merge docker/Makefile into new include Makefile.Docker.mk
  • define full list of platforms for binaries and for docker images in the Makefile
  • add echo targets to print those platforms and use them from scripts instead of hardcoding platforms in multiple places
  • refactor scripts/package-deploy.sh to loop through std list of platforms instead of hardcoding them, and drop dry_run flag which can be replaced with -p linux/amd64 for shorter runs

@renovate-bot renovate-bot requested a review from a team as a code owner August 31, 2024 05:42
@forking-renovate forking-renovate bot added the changelog:dependencies Update to dependencies label Aug 31, 2024
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (8ad6ed0) to head (07077fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5908   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files         342      342           
  Lines       16525    16525           
=======================================
  Hits        15998    15998           
  Misses        340      340           
  Partials      187      187           
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-3.x-v1 16.62% <ø> (ø)
cassandra-3.x-v2 1.75% <ø> (ø)
cassandra-4.x-v1 16.62% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.85% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.03% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.82% <ø> (ø)
grpc_v1 9.49% <ø> (ø)
grpc_v2 7.14% <ø> (-0.02%) ⬇️
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (+0.01%) ⬆️
opensearch-1.x-v1 18.89% <ø> (ø)
opensearch-2.x-v1 18.90% <ø> (ø)
opensearch-2.x-v2 1.82% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro changed the title Update module github.com/prometheus/common to v0.57.0 Refactor/cleanup makefile Aug 31, 2024
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro enabled auto-merge (squash) August 31, 2024 21:26
@yurishkuro yurishkuro merged commit edc3152 into jaegertracing:main Aug 31, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:dependencies Update to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants