[Draft] time window change on http api & spanstore interface

[rim99]

Which problem is this PR solving?

• Part of [Feature]: time parameters for querying trace by id #4150

Description of the changes

• Add optional time window when get trace by id on http API

This is only a draft to show how HTTP API would change based on the other PR #6242. Ideally, we should merge #6242 before this one.

How was this change tested?

• unit test

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (d6ca388) to head (e5824b8).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6258      +/-   ##
==========================================
- Coverage   96.46%   96.46%   -0.01%     
==========================================
  Files         355      355              
  Lines       20150    20208      +58     
==========================================
+ Hits        19438    19493      +55     
- Misses        525      527       +2     
- Partials      187      188       +1     

Flag	Coverage Δ
badger_v1	8.30% <5.55%> (-0.02%)	⬇️
badger_v2	1.67% <0.00%> (-0.01%)	⬇️
cassandra-4.x-v1	14.37% <8.33%> (-0.02%)	⬇️
cassandra-4.x-v2	1.61% <0.00%> (-0.01%)	⬇️
cassandra-5.x-v1	14.37% <8.33%> (-0.02%)	⬇️
cassandra-5.x-v2	1.61% <0.00%> (-0.01%)	⬇️
elasticsearch-6.x-v1	18.59% <8.33%> (-0.02%)	⬇️
elasticsearch-7.x-v1	18.67% <8.33%> (-0.02%)	⬇️
elasticsearch-8.x-v1	18.84% <8.33%> (-0.01%)	⬇️
elasticsearch-8.x-v2	1.67% <0.00%> (-0.01%)	⬇️
grpc_v1	9.54% <55.55%> (+0.09%)	⬆️
grpc_v2	7.01% <19.44%> (+0.03%)	⬆️
kafka-v1	8.87% <5.55%> (-0.02%)	⬇️
kafka-v2	1.67% <0.00%> (-0.01%)	⬇️
memory_v2	1.67% <0.00%> (+<0.01%)	⬆️
opensearch-1.x-v1	18.72% <8.33%> (-0.01%)	⬇️
opensearch-2.x-v1	18.72% <8.33%> (-0.01%)	⬇️
opensearch-2.x-v2	1.67% <0.00%> (-0.01%)	⬇️
tailsampling-processor	0.46% <0.00%> (-0.01%)	⬇️
unittests	95.37% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

@rim99 what is the relationship between this PR and #6242?

[rim99]

@rim99 what is the relationship between this PR and #6242?

This is a draft PR, containing changes of #6242 and on HTTP API layer, as requests here: #6242 (comment)

[yurishkuro]

sorry, I don't follow - are both PRs required and independent? It seems like I see similar changes in both.

[rim99]

sorry, I don't follow - are both PRs required and independent? It seems like I see similar changes in both.

No, this is only a draft to show how HTTP API would change based on the other PR #6242. Ideally, we should merge #6242 before this one. I've turn this PR as draft to avoid misunderstanding

[yurishkuro]

Thanks. In the future I recommend explaining this dependency in the PR description, not leaving it to guessing.

[rim99]

Close this since we don’t need demo anymore