-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][feat]: Support elasticsearch data stream #6551
base: main
Are you sure you want to change the base?
Conversation
@yurishkuro @zzzk1 My question for this PR is: Do we need to support |
@Manik2708 Thanks for your remind. Just for testing easily now; once all features are implemented, then migration to cmd/Jaeger will occur. |
35ae71b
to
cdbf97f
Compare
20d8aeb
to
ae5e6b6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6551 +/- ##
==========================================
- Coverage 96.24% 96.23% -0.02%
==========================================
Files 373 374 +1
Lines 21406 21439 +33
==========================================
+ Hits 20602 20631 +29
- Misses 612 615 +3
- Partials 192 193 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: zzzk1 <[email protected]>
Signed-off-by: zzzk1 <[email protected]>
1bb60d0
to
56b2b20
Compare
} | ||
|
||
// CreateOrUpdate Add or update a ILMPolicy | ||
func (i ILMClient) CreateOrUpdate(name string, ilmPolicy Policy) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how would our own code know what the policy should look like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a large new feature, please describe how you see everything working before jumping into implementation (which is likely going to be a waste of time if we don't agree on the approach first)
Yes, I will submit a descripton doc |
Which problem is this PR solving?
Resolves #4708
Provide follow API to client
Description of the changes
ilm_client
to create ILM Policy directlyHow was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test