Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2][storage] Implement reverse adapter to translate v2 writer to v1 #6555

Merged
merged 7 commits into from
Jan 17, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

How was this change tested?

  • Added unit tests

Checklist

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.22%. Comparing base (c36d588) to head (cb9d712).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6555      +/-   ##
==========================================
- Coverage   96.23%   96.22%   -0.01%     
==========================================
  Files         372      373       +1     
  Lines       21371    21378       +7     
==========================================
+ Hits        20567    20572       +5     
- Misses        612      614       +2     
  Partials      192      192              
Flag Coverage Δ
badger_v1 10.64% <0.00%> (-0.01%) ⬇️
badger_v2 2.77% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1-manual 16.54% <0.00%> (-0.02%) ⬇️
cassandra-4.x-v2-auto 2.71% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2-manual 2.71% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1-manual 16.54% <0.00%> (-0.02%) ⬇️
cassandra-5.x-v2-auto 2.71% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2-manual 2.71% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 20.32% <0.00%> (-0.01%) ⬇️
elasticsearch-7.x-v1 20.39% <0.00%> (-0.02%) ⬇️
elasticsearch-8.x-v1 20.55% <0.00%> (-0.02%) ⬇️
elasticsearch-8.x-v2 2.77% <0.00%> (-0.01%) ⬇️
grpc_v1 12.16% <0.00%> (-0.01%) ⬇️
grpc_v2 9.03% <0.00%> (-0.01%) ⬇️
kafka-3.x-v1 10.33% <0.00%> (-0.01%) ⬇️
kafka-3.x-v2 2.77% <0.00%> (-0.01%) ⬇️
memory_v2 2.77% <0.00%> (-0.01%) ⬇️
opensearch-1.x-v1 20.44% <0.00%> (-0.01%) ⬇️
opensearch-2.x-v1 20.44% <0.00%> (-0.03%) ⬇️
opensearch-2.x-v2 2.77% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.51% <0.00%> (-0.01%) ⬇️
unittests 95.11% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also rename reader/writer.go to tracereader/writer? This will make span/trace symmetrical in naming.

@mahadzaryab1 mahadzaryab1 enabled auto-merge (squash) January 17, 2025 00:32
@mahadzaryab1 mahadzaryab1 merged commit 7189b52 into jaegertracing:main Jan 17, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants