Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Motorola DS8611 #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamesmulcahy
Copy link

No description provided.

@jamesmulcahy
Copy link
Author

My Motorola DS8611 returns whitespace in one of the cells for the upstream channel information. I opted to do leading/trailing space trimming on all cells, since that seemed like it'd be more durable. It's probably fair to say that if one cell can get some leading whitespace, the others can too (if the values are low enough, perhaps).

I added a test including the exact output from my device -- and the existing tests continue to pass.

Let me know if you'd like any changes, @jahkeup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant