Added Time/Frequency Series SNR functionality #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! The only thing I would say is that there appears to be some duplication between the function |
|
I modified get_snr to have a variable / flag for series, and when it is present it just does what get_SNR_components used to do, it is a bit ugly in code but (so far) seems to have the same functionality |
removed if statement from get_snr function (reverted to previous functionality) renamed get_SNR_from_strains to get_SNR_from_series
Updated Tutorial for series SNR name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few functions to the utilities module to calculate the SNR of a Frequency series, and to transform a time series to a Frequency series.
Added a tutorial to quickly illustrate this in the form of a Notebook.