Added a server implementation alternative #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarwino
reviewed
Aug 8, 2021
|
|
||
| ## Running as a server | ||
| ```sh | ||
| python snag_yosemite_reservation.py --server |
There was a problem hiding this comment.
To be consistent with rest of README
Suggested change
| python snag_yosemite_reservation.py --server | |
| python3 snag_yosemite_reservation.py --server |
jarwino
reviewed
Aug 8, 2021
jarwino
reviewed
Aug 8, 2021
| from datetime import datetime, timedelta | ||
|
|
||
| def get_date(date): | ||
| #2021-08-26 |
There was a problem hiding this comment.
Suggested change
| #2021-08-26 | |
| # 2021-08-26 |
jarwino
reviewed
Aug 8, 2021
| ```sh | ||
| python snag_yosemite_reservation.py --server | ||
| ``` | ||
| Runs on port http port 80 |
There was a problem hiding this comment.
Seems redundant
Suggested change
| Runs on port http port 80 | |
| Runs on http port 80 |
jarwino
reviewed
Aug 8, 2021
| end = datetime.strptime(end, '%Y-%m-%d') | ||
|
|
||
| start_l = 0 | ||
| end_l = 30 |
There was a problem hiding this comment.
What does 30 represent? If this is related to # of days in a month, should this be 31, or even depend on the month?
Me too, bro |
jarwino
reviewed
Aug 8, 2021
| result = '' | ||
| if '|' in date: | ||
| dates = date.split('|') | ||
| if len(dates) == 2: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I WANNA GO HERE