Init seed with random value

jasp-stats · Nov 20, 2024 · 3e05f44 · 3e05f44
1 parent ba7bceb
commit 3e05f44
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 12 deletions.
diff --git a/inst/qml/auditClassicalModelFairness.qml b/inst/qml/auditClassicalModelFairness.qml
@@ -302,9 +302,11 @@ Form
 
 			IntegerField
 			{
-				name: 					"seed"
-				label: 					qsTr("Seed")
-				defaultValue: 			1
+				name:					"seed"
+				label:					qsTr("Seed")
+				defaultValue:			Math.floor(Math.random() * 1000); // Init with random integer in [1,...,999]
+				min:					-999
+				max:					999
 				info:					qsTr("Selects the seed for the random number generator in order to reproduce results.")
 			}
 		}

diff --git a/inst/qml/auditClassicalNumberBunching.qml b/inst/qml/auditClassicalNumberBunching.qml
@@ -217,9 +217,11 @@ Form
 
 			IntegerField
 			{
-				name: 					"seed"
-				label: 					qsTr("Seed")
-				defaultValue: 			1
+				name:					"seed"
+				label:					qsTr("Seed")
+				defaultValue:			Math.floor(Math.random() * 1000); // Init with random integer in [1,...,999]
+				min:					-999
+				max:					999
 				info:					qsTr("Selects the seed for the random number generator in order to reproduce results.")
 			}
 		}

diff --git a/inst/qml/common/selection/Seed.qml b/inst/qml/common/selection/Seed.qml
@@ -26,12 +26,12 @@ IntegerField
 {
 	property bool	enable:	false
 
-	id: 			seed
-	text: 			qsTr("Seed")
-	name: 			"seed"
-	defaultValue: 	1
-	min: 			1
-	max: 			99999
+	id:				seed
+	text:			qsTr("Seed")
+	name:			"seed"
+	defaultValue:	Math.floor(Math.random() * 1000); // Init with random integer in [1,...,999]
+	min:			-999
+	max:			999
 	enabled:		enable
 	info:			qsTr("Selects the seed for the random number generator in order to reproduce results.")
 }
diff --git a/tests/testthat/test-auditclassicalnumberbunching.R b/tests/testthat/test-auditclassicalnumberbunching.R
@@ -13,6 +13,7 @@ options$summaryTable <- TRUE
 options$numberBunchingSimulationPlots <- TRUE
 options$numberBunchingHistogram <- TRUE
 options$noHeads <- 0
+options$seed <- 1
 set.seed(1)
 results <- jaspTools::runAnalysis("auditClassicalNumberBunching", "numberBunching1.csv", options)
 
@@ -453,6 +454,7 @@ options$summaryTable <- TRUE
 options$numberBunchingSimulationPlots <- TRUE
 options$numberBunchingHistogram <- TRUE
 options$noHeads <- 0
+options$seed <- 1
 set.seed(1)
 results <- jaspTools::runAnalysis("auditClassicalNumberBunching", "numberBunching2.csv", options)