-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code at head, pytype errors, and small Event refactoring #50
base: main
Are you sure you want to change the base?
Conversation
Ended up fixing this as well here: callebtc#5. The This is a great PR. LGTM. |
Thanks @callebtc @jeffthibault WDYT? could be three separate prs:
Looking for feedback before doing anything else here FWIW, here is the relevant pytype failures wrt the Event() breakage:
I'm a big fan of using pytype to catch these breakages. |
Bumping this one, would love to see it get merged. |
been 2 months since a merge. guessing @jeffthibault is asleep. thinking either (a) fork or (b) ask jeff to promote a couple maintainers... clearly no lack of people want to help |
Code was broken at head after yesterday's Event dataclass refactoring.
pytype would have caught this error. So I fixed all the outstanding pytype errors in anticipation of (hopefully) adding some automated pytype checking to the repo.