-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a complete comment system for minima #702
base: master
Are you sure you want to change the base?
Conversation
Hello @YURLAK, Regarding your pull request, I love the idea but would like to leave some feedback nevertheless:
|
Hello,@ashmaroli.Thanks for your feedback!According to your feedback,I made some changes.Readability does matter,I updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typographic suggestions.
|
||
Optionally, if you have a Disqus account, you can tell Jekyll to use it to show a comments section below each post. | ||
If you want to add comment system for your site,add the following code to the `README.md` file.If not,skip this part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to add comment system for your site,add the following code to the `README.md` file.If not,skip this part. | |
If you want to add comment system for your site, add the following code to the `README.md` file. If not, skip this part. |
label: "Comments" | ||
theme: "your_theme" | ||
|
||
# You must install giscus github app before use.(https://github.com/apps/giscus) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# You must install giscus github app before use.(https://github.com/apps/giscus) | |
# You must install giscus github app before use (https://github.com/apps/giscus). |
@YURLAK I thought about this bit more. Continuing from previous feedback:
So, our {% if jekyll.environment == "production" %}
{% unless page.comments == "disabled" %}
{% assign comments_provider == site.minima.comments_provider %}
{% if comments_provider %}
{% capture provider_filepath %}comments/{{ comments_provider }}.html{% endcapture %}
{% include {{ provider_filepath }} %}
{% endif %}
{% endunless %}
{% endif %} Then, we document what users need to do, in our README along with the note that build will fail if user does not provide associated include file. |
Co-authored-by: Louis Royer <[email protected]>
Co-authored-by: Louis Royer <[email protected]>
Hello, developers!👋This is my first PR.
Problem.
Minima has less comment system.And disqus has been deprecated.
How to realize it?
I changed three places.
/includes/comments.html
,Delete/includes/disqus_comments.html
._config.yml
._layouts/post.html
.At last
After my changes.Now Giscus,Utterance and Disqus are available now.
I tested it successfully on my blog.
And that's all.Thanks😀