Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes YUI usages from the plugin #400

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alecharp
Copy link
Member

This is a follow up pull request of jenkinsci/jenkins#10135. This is to ensure the buttons still look appropriate if the plugin is used on a controller with no YUI available.

  • Associate build to release
Before

Screenshot 2025-01-14 at 10 59 01

After

Screenshot 2025-01-14 at 11 12 15

  • Deploy application
Before

Screenshot 2025-01-14 at 11 21 35

After

Screenshot 2025-01-14 at 11 22 12

  • Pipeline publisher
Before

Screenshot 2025-01-14 at 11 26 45

After

Screenshot 2025-01-14 at 11 27 39

  • Run procedure
Before

Screenshot 2025-01-14 at 11 28 23

After

Screenshot 2025-01-14 at 11 29 13

  • Trigger release
Before

Screenshot 2025-01-14 at 11 29 35

After

Screenshot 2025-01-14 at 11 30 19

Testing done

I took screenshots before and after the change. No actions were triggered.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@alecharp alecharp requested a review from a team as a code owner January 14, 2025 10:39
Copy link

@scherler scherler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecharp
Copy link
Member Author

@jenkinsci/electricflow-plugin-developers do you think you could review this and potentially merge and release the plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants