Promotion Badge refactoring #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonbrohauge
reviewed
Jun 6, 2019
| * @param build | ||
| * The calling build. Never null. | ||
| * @param run | ||
| * The calling run. Never null | ||
| * @param env | ||
| * Environment variables should be added to this map. | ||
| */ |
jonbrohauge
reviewed
Jun 6, 2019
| * @param build | ||
| * The calling build. Never null. | ||
| * @param run | ||
| * The calling run. Never null. | ||
| * @param env | ||
| * Environment variables should be added to this map. | ||
| */ |
oleg-nenashev
requested changes
Jun 6, 2019
There was a problem hiding this comment.
This commit does not retain the original commit history from #128.
If it was not me, it could have led to a code of conduct escalation. Committers are not expected to take code from other committers without proper referencing
Just build your solution on the top of my PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Link for the PR: https://issues.jenkins-ci.org/browse/JENKINS-57877
CC: @oleg-nenashev @jonbrohauge @bicschneider