Skip to content

Commit

Permalink
Fix Ruby 2.3 CI
Browse files Browse the repository at this point in the history
base64 0.1.0 doesn't work with Ruby 2.3, despite the
required_ruby_version stating otherwise.  Looks like base64 is
pulled in by rack-protection via sinatra, so limit the sinatra
version to fix things.
  • Loading branch information
jeremyevans committed Mar 28, 2024
1 parent 586c088 commit 1d0f031
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions .ci.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,6 @@ if RUBY_VERSION < '2.5'
gem 'loofah', '< 2.20'
end

if RUBY_VERSION >= '2.3' && RUBY_VERSION < '2.4'
gem 'base64', '0.1.0'
end

if RUBY_VERSION < '2.2'
gem 'rails', '< 5'
gem 'nokogiri', '< 1.7'
Expand All @@ -86,6 +82,8 @@ end

if RUBY_VERSION < '2.2'
gem 'sinatra', '< 2'
elsif RUBY_VERSION < '2.4'
gem 'sinatra', '< 3.2'
else
gem 'sinatra'
end
Expand Down

0 comments on commit 1d0f031

Please sign in to comment.