Skip to content

Commit

Permalink
Fix check
Browse files Browse the repository at this point in the history
  • Loading branch information
jeroen committed Jun 7, 2024
1 parent 9a86533 commit 3fb0f9f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export(v8)
export(wasm)
export(wasm_features)
if (getRversion() >= "4.3.0" && !is.null(asNamespace("utils")$.AtNames)) S3method(utils::.AtNames,V8)
if (getRversion() >= "4.3.0") S3method(base::`@`, V8) else export("@")
if (getRversion() >= "4.3.0") S3method(base::`@`, V8)
import(Rcpp)
importFrom(curl,curl)
importFrom(jsonlite,fromJSON)
Expand Down
2 changes: 1 addition & 1 deletion NEWS
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
5.0.0
- Drop support for legacy v8-314 library
- Compile with C++20 when available (required as of libv8 version 12.7)
- Enable @ instead of $ syntax for accessing v8 fields
- Enable @ accessor for v8 objects in R >= 4.3.0

4.4.2
- Prevent Fedora from accidentally building against the legacy v8-314 library
Expand Down
2 changes: 1 addition & 1 deletion R/V8.R
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ print.V8 <- function(x, ...){
}

#' @export
#' @rawNamespace if (getRversion() >= "4.3.0") S3method(base::`@`, V8) else export("@")
#' @rawNamespace if (getRversion() >= "4.3.0") S3method(base::`@`, V8)
`@.V8` <- function(object, name, ...){
object[[name]]
}
Expand Down

0 comments on commit 3fb0f9f

Please sign in to comment.