feat: add a check/prompt box when invalid metadata is extracted (reso…

…lves #12) feat: update program to support latest versions of FFMPEG (fixes #13)
jessielw · Jan 24, 2024 · ce599ee · ce599ee
1 parent 0d4ed7c
commit ce599ee
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/electron/app/main/ipc_handlers/ipcJobHandler.js b/electron/app/main/ipc_handlers/ipcJobHandler.js
@@ -6,6 +6,7 @@ const {
 } = require("../../../app/main/logToFile");
 const path = require("path");
 const createConfigStore = require("../../../app/main/configUtils.js");
+const fs = require("fs");
 // const getFileObject = require("../../../app/main/fileUtils").changeFileExtension;
 
 // function convertFFmpegToPercent(line, durationInSeconds) {
@@ -39,6 +40,13 @@ function convertFFmpegFrameCountToPercent(line, totalFrames) {
   return 0;
 }
 
+function checkValidOutput(filePath, root) {
+  const getSize = fs.statSync(filePath).size;
+  if (getSize == 0) {
+    root.webContents.send("invalid-output", filePath);
+  }
+}
+
 module.exports = (root) => {
   let currentJob = 0;
   const jobQueue = { uncompleted: [], failed: [], inProgress: [] };
@@ -51,6 +59,7 @@ module.exports = (root) => {
     const modifiedJobCommand = {
       currentJob: currentJob,
       fileName: args.fileName,
+      outputPath: args.outputPath,
       pipe1: args.pipe1,
       pipe2: args.pipe2,
       // duration: args.duration,
@@ -181,6 +190,7 @@ module.exports = (root) => {
     await new Promise((resolve) => {
       hdrProcess.on("close", (exitCode) => {
         if (complete) {
+          checkValidOutput(job.outputPath, root);
           root.webContents.send("reset-job-progress");
         }
         resolve();

diff --git a/electron/app/renderer/js/renderer.js b/electron/app/renderer/js/renderer.js
@@ -355,7 +355,7 @@ addJobButton.addEventListener("click", async function () {
     "0:v:0",
     "-c:v:0",
     "copy",
-    "-vbsf",
+    "-bsf:v",
     "hevc_mp4toannexb",
     "-f",
     "hevc",
@@ -408,6 +408,7 @@ addJobButton.addEventListener("click", async function () {
   if (hdr10PlusCheckBox.checked || dVCheckBox.checked) {
     const addJob = await ipcRenderer.invoke("add-job", {
       fileName: inputFileName,
+      outputPath: outputPath,
       pipe1: pipe1,
       pipe2: pipe2,
       frameCount: videoTrackFrameCount,
@@ -525,6 +526,13 @@ ipcRenderer.on("job-complete", () => {
   startJobButton.style.display = "flex";
 });
 
+ipcRenderer.on("invalid-output", (filePath) => {
+  ipcRenderer.send("show-message-prompt", [
+    "Error",
+    `There was an error parsing metadata, input likely has invalid HDR metadata.\n\nInvalid output:\n${filePath}`,
+  ]);
+});
+
 ipcRenderer.on("update-job-progress", (progress) => {
   const computedStyle = window.getComputedStyle(queuePanelProgressBox);
   if (computedStyle.getPropertyValue("display") !== "flex") {