changes to make compatible with jsdom 2.0.0-4.0.1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to use the code with jsdom v3 or v4, I found that I needed to make some small changes to the setup code. I tested the code against 2.0.0 and it works as well, so it would appear to be safe to switch to this for better compatibility with newer versions. global.navigator was needed when I started testing with events.
|
+1 Recommend merging this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use the code with jsdom v3 or v4, I found that I needed to make some small changes to the setup code.
I also back tested the code against [email protected] and it works as well, so it would appear to be safe to switch to this for better compatibility with newer versions.
global.navigator was needed when I started testing with events, so I included it as well.