Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON: add support for default repeating values #149

Merged
merged 10 commits into from
Oct 8, 2020
Merged

JSON: add support for default repeating values #149

merged 10 commits into from
Oct 8, 2020

Conversation

Alma-media
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #149 into master will increase coverage by 0.78%.
The diff coverage is 86.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   82.70%   83.48%   +0.78%     
==========================================
  Files         130      134       +4     
  Lines        5798     5784      -14     
==========================================
+ Hits         4795     4829      +34     
+ Misses        682      638      -44     
+ Partials      321      317       -4     
Impacted Files Coverage Δ
pkg/codec/xml/xml.go 64.06% <0.00%> (ø)
pkg/codec/json/types.go 85.20% <60.00%> (-11.77%) ⬇️
pkg/codec/json/json.go 75.00% <75.00%> (+37.06%) ⬆️
pkg/codec/json/decode.go 84.21% <84.21%> (ø)
pkg/codec/json/enum.go 84.84% <84.84%> (ø)
pkg/codec/json/array.go 84.00% <90.90%> (+49.88%) ⬆️
pkg/codec/json/scalar.go 91.66% <91.66%> (ø)
pkg/codec/json/encode.go 100.00% <100.00%> (ø)
pkg/codec/json/errors.go 100.00% <100.00%> (ø)
pkg/codec/json/object.go 71.42% <100.00%> (-3.28%) ⬇️
... and 5 more

@jeroenrinzema jeroenrinzema added this to the v2.0.0 milestone Oct 7, 2020
@jeroenrinzema jeroenrinzema added the enhancement New feature or request label Oct 7, 2020
@jeroenrinzema
Copy link
Contributor

I have included a temp fix to satisfy the linter by ignoring the gojay vendor directory. This ignore should be removed once the PR over at francoispqt/gojay has been merged (francoispqt/gojay#157)

@jeroenrinzema jeroenrinzema merged commit c22cd97 into master Oct 8, 2020
@jeroenrinzema jeroenrinzema deleted the json branch October 8, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants