Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multi Repository Scanning #510

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Sep 20, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Git Repo param is not mandatory for scan-and-fix-repos command

@EyalDelarea EyalDelarea added the bug Something isn't working label Sep 20, 2023
@EyalDelarea EyalDelarea temporarily deployed to frogbot September 20, 2023 14:56 — with GitHub Actions Inactive
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 20, 2023
assert.Equal(t, "dev", configParams.Branches[0])
assert.Equal(t, int64(0), configParams.PullRequestDetails.ID)
assert.Equal(t, "my-custom-commit-template", configParams.Git.CommitMessageTemplate)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed template check as this is tested in other function and this is not generic to the test

@github-actions
Copy link
Contributor


@EyalDelarea EyalDelarea merged commit e8ac541 into jfrog:dev Sep 20, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants