Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bad API endpoint error hint #513

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

EyalDelarea
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@EyalDelarea EyalDelarea added the ignore for release Automatically generated release notes label Sep 21, 2023
utils/params.go Outdated Show resolved Hide resolved
utils/params.go Outdated Show resolved Hide resolved
Copy link
Contributor

@sverdlov93 sverdlov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errors start with lowercase
logs start with uppercase

@EyalDelarea EyalDelarea changed the title Add error hint Improve bad API endpoint error hint Sep 26, 2023
@EyalDelarea EyalDelarea merged commit 38d69f5 into jfrog:dev Sep 26, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants