Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry download schema for tests #538

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Retry download schema for tests #538

merged 6 commits into from
Oct 12, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Oct 11, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@attiasas attiasas added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Oct 11, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 11, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 11, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 11, 2023
@attiasas attiasas marked this pull request as ready for review October 11, 2023 11:12
@attiasas attiasas requested a review from eyalbe4 October 11, 2023 11:12
@github-actions
Copy link
Contributor

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 11, 2023
@attiasas attiasas requested a review from yahavi October 11, 2023 11:30
@attiasas attiasas changed the title Retry to download schema for tests Retry download schema for tests Oct 11, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 11, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 11, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 11, 2023
yahavi
yahavi requested changes Oct 11, 2023
View reviewed changes
schema/schemas_test.go Outdated Show resolved Hide resolved
schema/schemas_test.go Outdated Show resolved Hide resolved
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 11, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 11, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 11, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 11, 2023
@attiasas attiasas merged commit c3daa70 into jfrog:dev Oct 12, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@attiasas @eyalbe4 @yahavi